diff options
| author | Ting-Wei Lan <lantw44@gmail.com> | 2014-06-15 05:18:04 +0800 |
|---|---|---|
| committer | Ting-Wei Lan <lantw44@gmail.com> | 2014-06-15 05:18:04 +0800 |
| commit | a82746366aafcd20c8063143d3620dba20fdbc21 (patch) | |
| tree | b98982003d42c66ded86ac5cf69b4faed39becdb | |
| parent | 20feaf8719052e602409ab12f2c270a08aca994c (diff) | |
| download | fastalg-protocol-a82746366aafcd20c8063143d3620dba20fdbc21.tar.gz fastalg-protocol-a82746366aafcd20c8063143d3620dba20fdbc21.tar.zst fastalg-protocol-a82746366aafcd20c8063143d3620dba20fdbc21.zip | |
Document the result of the param_getter
| -rw-r--r-- | falgproto/falgproto-protocol-dns.c | 4 | ||||
| -rw-r--r-- | falgproto/falgproto.h | 9 |
2 files changed, 7 insertions, 6 deletions
diff --git a/falgproto/falgproto-protocol-dns.c b/falgproto/falgproto-protocol-dns.c index 097ab61..1dcc675 100644 --- a/falgproto/falgproto-protocol-dns.c +++ b/falgproto/falgproto-protocol-dns.c @@ -101,7 +101,7 @@ FALGPROTO_PARAM_GETTER_DECL (dns) { uint16_t question_count; if (get_question_count (payload, len, &question_count) < 0) { - return (FalgprotoParam) { .result = FALGPROTO_PARAM_RESULT_TRUNCATED }; + return (FalgprotoParam) { .result = FALGPROTO_PARAM_RESULT_BAD_FORMAT }; } if (question_count == 0) { return (FalgprotoParam) { .result = FALGPROTO_PARAM_RESULT_NOT_FOUND }; @@ -109,7 +109,7 @@ FALGPROTO_PARAM_GETTER_DECL (dns) { ssize_t question_name_len = get_question_name (payload, len, NULL); if (question_name_len < 0) { - return (FalgprotoParam) { .result = FALGPROTO_PARAM_RESULT_TRUNCATED }; + return (FalgprotoParam) { .result = FALGPROTO_PARAM_RESULT_BAD_FORMAT }; } char *question_name = malloc (question_name_len + 1); diff --git a/falgproto/falgproto.h b/falgproto/falgproto.h index cf9d57e..a76dd72 100644 --- a/falgproto/falgproto.h +++ b/falgproto/falgproto.h @@ -34,10 +34,11 @@ typedef struct falgproto_param { int result; /* error code listed below */ } FalgprotoParam; -#define FALGPROTO_PARAM_RESULT_ERROR -1 -#define FALGPROTO_PARAM_RESULT_OK 0 -#define FALGPROTO_PARAM_RESULT_NOT_FOUND 1 -#define FALGPROTO_PARAM_RESULT_TRUNCATED 2 +#define FALGPROTO_PARAM_RESULT_BAD_FORMAT -3 /* ERROR: bad packet format */ +#define FALGPROTO_PARAM_RESULT_NOT_FOUND -2 /* ERROR: param is missing */ +#define FALGPROTO_PARAM_RESULT_ERROR -1 /* ERROR: internal system error */ +#define FALGPROTO_PARAM_RESULT_OK 0 /* param has successfully got */ +#define FALGPROTO_PARAM_RESULT_TRUNCATED 1 /* needs more data */ typedef FalgprotoParam (*FalgprotoParamGetter) (FalgprotoPacket *pkt); typedef void (*FalgprotoPrinter) (FILE *fp, FalgprotoPacket *pkt); |