From 3da1bf8ca18f54d9bd2c8c110854dc071ee3898b Mon Sep 17 00:00:00 2001
From: Zach <zach.ramsay@gmail.com>
Date: Tue, 12 Dec 2017 18:05:47 +0000
Subject: all: use gometalinter.v2, fix new gosimple issues (#15650)
---
console/console_test.go | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
(limited to 'console/console_test.go')
diff --git a/console/console_test.go b/console/console_test.go
index 05aec2cc0..7b1629c03 100644
--- a/console/console_test.go
+++ b/console/console_test.go
@@ -164,7 +164,7 @@ func TestWelcome(t *testing.T) {
tester.console.Welcome()
- output := string(tester.output.Bytes())
+ output := tester.output.String()
if want := "Welcome"; !strings.Contains(output, want) {
t.Fatalf("console output missing welcome message: have\n%s\nwant also %s", output, want)
}
@@ -188,7 +188,7 @@ func TestEvaluate(t *testing.T) {
defer tester.Close(t)
tester.console.Evaluate("2 + 2")
- if output := string(tester.output.Bytes()); !strings.Contains(output, "4") {
+ if output := tester.output.String(); !strings.Contains(output, "4") {
t.Fatalf("statement evaluation failed: have %s, want %s", output, "4")
}
}
@@ -218,7 +218,7 @@ func TestInteractive(t *testing.T) {
case <-time.After(time.Second):
t.Fatalf("secondary prompt timeout")
}
- if output := string(tester.output.Bytes()); !strings.Contains(output, "4") {
+ if output := tester.output.String(); !strings.Contains(output, "4") {
t.Fatalf("statement evaluation failed: have %s, want %s", output, "4")
}
}
@@ -230,7 +230,7 @@ func TestPreload(t *testing.T) {
defer tester.Close(t)
tester.console.Evaluate("preloaded")
- if output := string(tester.output.Bytes()); !strings.Contains(output, "some-preloaded-string") {
+ if output := tester.output.String(); !strings.Contains(output, "some-preloaded-string") {
t.Fatalf("preloaded variable missing: have %s, want %s", output, "some-preloaded-string")
}
}
@@ -243,7 +243,7 @@ func TestExecute(t *testing.T) {
tester.console.Execute("exec.js")
tester.console.Evaluate("execed")
- if output := string(tester.output.Bytes()); !strings.Contains(output, "some-executed-string") {
+ if output := tester.output.String(); !strings.Contains(output, "some-executed-string") {
t.Fatalf("execed variable missing: have %s, want %s", output, "some-executed-string")
}
}
@@ -275,7 +275,7 @@ func TestPrettyPrint(t *testing.T) {
string: ` + two + `
}
`
- if output := string(tester.output.Bytes()); output != want {
+ if output := tester.output.String(); output != want {
t.Fatalf("pretty print mismatch: have %s, want %s", output, want)
}
}
@@ -287,7 +287,7 @@ func TestPrettyError(t *testing.T) {
tester.console.Evaluate("throw 'hello'")
want := jsre.ErrorColor("hello") + "\n"
- if output := string(tester.output.Bytes()); output != want {
+ if output := tester.output.String(); output != want {
t.Fatalf("pretty error mismatch: have %s, want %s", output, want)
}
}
--
cgit